]> www.infradead.org Git - users/willy/pagecache.git/commit
x86/sev: Disable jump tables in SEV startup code
authorArd Biesheuvel <ardb@kernel.org>
Mon, 27 Jan 2025 11:43:37 +0000 (12:43 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 28 Jan 2025 22:10:29 +0000 (23:10 +0100)
commit1105ab42a84bc11c62597005f78ccad2434fbd66
tree7955dce0fea4dacf197f7be682bde2a744ffc422
parent9c5968db9e625019a0ee5226c7eebef5519d366a
x86/sev: Disable jump tables in SEV startup code

When retpolines and IBT are both disabled, the compiler is free to use
jump tables to optimize switch instructions. However, these are emitted
by Clang as absolute references into .rodata:

        jmp    *-0x7dfffe90(,%r9,8)
                        R_X86_64_32S    .rodata+0x170

Given that this code will execute before that address in .rodata has even
been mapped, it is guaranteed to crash a SEV-SNP guest in a way that is
difficult to diagnose.

So disable jump tables when building this code. It would be better if we
could attach this annotation to the __head macro but this appears to be
impossible.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20250127114334.1045857-6-ardb+git@google.com
arch/x86/coco/sev/Makefile