]> www.infradead.org Git - users/jedix/linux-maple.git/commit
r8169: avoid unsolicited interrupts
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 18 Oct 2024 09:08:16 +0000 (11:08 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 23 Oct 2024 13:41:27 +0000 (15:41 +0200)
commit10ce0db787004875f4dba068ea952207d1d8abeb
tree92dce8cc19097a99665a7aead1f905ad67d4af28
parentb22db8b8befe90b61c98626ca1a2fbb0505e9fe3
r8169: avoid unsolicited interrupts

It was reported that after resume from suspend a PCI error is logged
and connectivity is broken. Error message is:
PCI error (cmd = 0x0407, status_errs = 0x0000)
The message seems to be a red herring as none of the error bits is set,
and the PCI command register value also is normal. Exception handling
for a PCI error includes a chip reset what apparently brakes connectivity
here. The interrupt status bit triggering the PCI error handling isn't
actually used on PCIe chip versions, so it's not clear why this bit is
set by the chip. Fix this by ignoring this bit on PCIe chip versions.

Fixes: 0e4851502f84 ("r8169: merge with version 8.001.00 of Realtek's r8168 driver")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219388
Tested-by: Atlas Yu <atlas.yu@canonical.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/78e2f535-438f-4212-ad94-a77637ac6c9c@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/realtek/r8169_main.c