]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/mediatek: dp: drm_err => dev_err in HPD path to avoid NULL ptr
authorDouglas Anderson <dianders@chromium.org>
Thu, 16 Jan 2025 17:42:50 +0000 (09:42 -0800)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Wed, 12 Mar 2025 23:17:22 +0000 (23:17 +0000)
commit106a6de46cf4887d535018185ec528ce822d6d84
tree2360a213c7325c301db9149cbd616d06fa425229
parent4ba973c8bad04d59fd4efa62512f4d9cee131714
drm/mediatek: dp: drm_err => dev_err in HPD path to avoid NULL ptr

The function mtk_dp_wait_hpd_asserted() may be called before the
`mtk_dp->drm_dev` pointer is assigned in mtk_dp_bridge_attach().
Specifically it can be called via this callpath:
 - mtk_edp_wait_hpd_asserted
 - [panel probe]
 - dp_aux_ep_probe

Using "drm" level prints anywhere in this callpath causes a NULL
pointer dereference. Change the error message directly in
mtk_dp_wait_hpd_asserted() to dev_err() to avoid this. Also change the
error messages in mtk_dp_parse_capabilities(), which is called by
mtk_dp_wait_hpd_asserted().

While touching these prints, also add the error code to them to make
future debugging easier.

Fixes: 7eacba9a083b ("drm/mediatek: dp: Add .wait_hpd_asserted() for AUX bus")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20250116094249.1.I29b0b621abb613ddc70ab4996426a3909e1aa75f@changeid/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_dp.c