]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf dsos: When adding a dso into sorted dsos maintain the sort order
authorIan Rogers <irogers@google.com>
Wed, 3 Jul 2024 17:21:17 +0000 (10:21 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Wed, 3 Jul 2024 22:02:53 +0000 (15:02 -0700)
commit1059fb529114a4ac524e4c366f0a0933810efddf
tree55db06843463793e946c86eca62ef165a00e08b9
parentfeaaa8be0b1efce6e8fb4222654413246bdc30aa
perf dsos: When adding a dso into sorted dsos maintain the sort order

dsos__add would add at the end of the dso array possibly requiring a
later find to re-sort the array. Patterns of find then add were
becoming O(n*log n) due to the sorts. Change the add routine to be
O(n) rather than O(1) but to maintain the sorted-ness of the dsos
array so that later finds don't need the O(n*log n) sort.

Fixes: 3f4ac23a9908 ("perf dsos: Switch backing storage to array from rbtree/list")
Reported-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Steinar Gunderson <sesse@google.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Matt Fleming <matt@readmodwrite.com>
Link: https://lore.kernel.org/r/20240703172117.810918-3-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/dsos.c