]> www.infradead.org Git - users/jedix/linux-maple.git/commit
Bluetooth: hci_qca: move the SoC type check to the right place
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 27 May 2025 07:47:37 +0000 (09:47 +0200)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 30 May 2025 17:29:38 +0000 (13:29 -0400)
commit0fb410c914eb03c7e9d821e26d03bac0a239e5db
tree62d52685a5e2df2753a3bd487f032e64068d9884
parentedc14f2adc6401d67bf73828d9135c80d32615a2
Bluetooth: hci_qca: move the SoC type check to the right place

Commit 3d05fc82237a ("Bluetooth: qca: set power_ctrl_enabled on NULL
returned by gpiod_get_optional()") accidentally changed the prevous
behavior where power control would be disabled without the BT_EN GPIO
only on QCA_WCN6750 and QCA_WCN6855 while also getting the error check
wrong. We should treat every IS_ERR() return value from
devm_gpiod_get_optional() as a reason to bail-out while we should only
set power_ctrl_enabled to false on the two models mentioned above. While
at it: use dev_err_probe() to save a LOC.

Cc: stable@vger.kernel.org
Fixes: 3d05fc82237a ("Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional()")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Hsin-chen Chuang <chharry@chromium.org>
Reviewed-by: Hsin-chen Chuang <chharry@chromium.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/hci_qca.c