]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fs/stat.c: avoid harmless garbage value problem in vfs_statx_path()
authorSu Hui <suhui@nfschina.com>
Sun, 19 Jan 2025 02:59:47 +0000 (10:59 +0800)
committerChristian Brauner <brauner@kernel.org>
Fri, 7 Feb 2025 09:27:24 +0000 (10:27 +0100)
commit0fac3ed473dd2955053be6671cdd747807f5e488
treeed03e5eb7992abe3e0e1e2b71ede008a3a121f60
parent2014c95afecee3e76ca4a56956a936e23283f05b
fs/stat.c: avoid harmless garbage value problem in vfs_statx_path()

Clang static checker(scan-build) warning:
fs/stat.c:287:21: warning: The left expression of the compound assignment is
an uninitialized value. The computed value will also be garbage.
  287 |                 stat->result_mask |= STATX_MNT_ID_UNIQUE;
      |                 ~~~~~~~~~~~~~~~~~ ^
fs/stat.c:290:21: warning: The left expression of the compound assignment is
an uninitialized value. The computed value will also be garbage.
  290 |                 stat->result_mask |= STATX_MNT_ID;

When vfs_getattr() failed because of security_inode_getattr(), 'stat' is
uninitialized. In this case, there is a harmless garbage problem in
vfs_statx_path(). It's better to return error directly when
vfs_getattr() failed, avoiding garbage value and more clearly.

Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20250119025946.1168957-1-suhui@nfschina.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/stat.c