]> www.infradead.org Git - users/dwmw2/linux.git/commit
ALSA: hda: Hardening for potential Spectre v1
authorTakashi Iwai <tiwai@suse.de>
Tue, 24 Apr 2018 05:50:50 +0000 (07:50 +0200)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:38 +0000 (21:36 -0400)
commit0f80b5548fa38ca8b39c87b6d63d848d6628690a
tree69d61e40ed1b4f3509c779b6b6fe6e664d944511
parent9ad08cc48adcd4d8cd58a6d748a7b4b30b0d0d96
ALSA: hda: Hardening for potential Spectre v1

[ Upstream commit 69fa6f19b95597618ab30438a27b67ad93daa7c7 ]

As recently Smatch suggested, one place in HD-audio hwdep ioctl codes
may expand the array directly from the user-space value with
speculation:
  sound/pci/hda/hda_local.h:467 get_wcaps() warn: potential spectre issue 'codec->wcaps'

As get_wcaps() itself is a fairly frequently called inline function,
and there is only one single call with a user-space value, we replace
only the latter one to open-code locally with array_index_nospec()
hardening in this patch.

BugLink: https://marc.info/?l=linux-kernel&m=152411496503418&w=2
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
sound/pci/hda/hda_hwdep.c