]> www.infradead.org Git - users/dwmw2/linux.git/commit
lib82596: Fix IRQ check in sni_82596_probe
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 14 Jan 2022 06:57:24 +0000 (06:57 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:04:33 +0000 (09:04 +0100)
commit0f604bfdb56457c903005eb4e2a6d69c8b87811e
tree3772c7e45e99cdb7cd362dee4020fda58f8613de
parentfe02c43440d2ff26e33c523b3908c56ceae35390
lib82596: Fix IRQ check in sni_82596_probe

commit 99218cbf81bf21355a3de61cd46a706d36e900e6 upstream.

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 115978859272 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/i825xx/sni_82596.c