]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dm btree: fix bufio buffer leaks in dm_btree_del() error path
authorJoe Thornber <ejt@redhat.com>
Thu, 10 Dec 2015 14:37:53 +0000 (14:37 +0000)
committerChuck Anderson <chuck.anderson@oracle.com>
Mon, 27 Feb 2017 23:09:16 +0000 (15:09 -0800)
commit0f5f215d74bafe2271fa6dbbf2dc32dee57eb9b3
tree3653de25da814ccd2bdb9ce1bdeef4f0cf2f4402
parentbe7d69cb44e14b1957615c2c0eab9c8474247384
dm btree: fix bufio buffer leaks in dm_btree_del() error path

Orabug: 25550785

If dm_btree_del()'s call to push_frame() fails, e.g. due to
btree_node_validator finding invalid metadata, the dm_btree_del() error
path must unlock all frames (which have active dm-bufio buffers) that
were pushed onto the del_stack.

Otherwise, dm_bufio_client_destroy() will BUG_ON() because dm-bufio
buffers have leaked, e.g.:
  device-mapper: bufio: leaked buffer 3, hold count 1, list 0

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
(cherry picked from commit ed8b45a3679eb49069b094c0711b30833f27c734)
Signed-off-by: Somasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
drivers/md/persistent-data/dm-btree.c