]> www.infradead.org Git - users/hch/misc.git/commit
block: protect debugfs attribute method hctx_busy_show
authorNilay Shroff <nilay@linux.ibm.com>
Thu, 13 Mar 2025 11:51:52 +0000 (17:21 +0530)
committerJens Axboe <axboe@kernel.dk>
Thu, 13 Mar 2025 13:23:43 +0000 (07:23 -0600)
commit0e94ed33681424a6dce65c62837e08e4c7aa09ac
treecb95082667f464c5bd14eed5af97b99d0c83e7e1
parent78800f5997d8ae0f20d4aced66a524f0f2fc4c7f
block: protect debugfs attribute method hctx_busy_show

The hctx_busy_show method in debugfs is currently unprotected. This
method iterates over all started requests in a tagset and prints them.
However, the tags can be updated concurrently via the sysfs attributes
'nr_requests' or 'scheduler' (elevator switch), leading to potential
race conditions.

Since sysfs attributes 'nr_requests' and 'scheduler' are already
protected using q->elevator_lock, extend this protection to the debugfs
'busy' attribute as well to ensure consistency.

Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250313115235.3707600-4-nilay@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-debugfs.c