]> www.infradead.org Git - users/dwmw2/linux.git/commit
scsi: aacraid: fix a signedness bug
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 27 Aug 2018 09:23:01 +0000 (12:23 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Oct 2018 06:55:51 +0000 (08:55 +0200)
commit0dcf1bcde827e6ac96c52cc08e4b01f8aa110f73
tree71033374f92536317062d39c9c9a95c0f683d468
parentc08d2054307f7fbc0fc7ed98dac6933792057fba
scsi: aacraid: fix a signedness bug

[ Upstream commit b9eb3b14f1dbf16bf27b6c1ffe6b8c00ec945c9b ]

The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in
aac_tmf_callback() and the error handling in aac_eh_target_reset() relies
on it to be signed.

[mkp: fixed typo]

Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/aacraid/aacraid.h