]> www.infradead.org Git - users/willy/linux.git/commit
ipmi: kcs_bmc: handle devm_kasprintf() failure case
authorNicholas Mc Guire <hofrat@osadl.org>
Wed, 21 Nov 2018 15:08:25 +0000 (16:08 +0100)
committerCorey Minyard <cminyard@mvista.com>
Wed, 28 Nov 2018 00:54:52 +0000 (18:54 -0600)
commit0dbc27536f6dc2cf38e89c89d4eaa67402df08f4
tree94bef784c6a73d4a3b4e6b35205c7a7b1d0a17c8
parentae5f2fa3bc7675b3e3ae8ebd513176567c75fff3
ipmi: kcs_bmc: handle devm_kasprintf() failure case

devm_kasprintf() may return NULL if internal allocation failed so this
assignment is not safe. Moved the error exit path and added the !NULL
which then allows the devres manager to take care of cleanup.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: cd2315d471f4 ("ipmi: kcs_bmc: don't change device name")
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
drivers/char/ipmi/kcs_bmc.c