]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/meson: fix more rounding issues with 59.94Hz modes
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Mon, 9 Jun 2025 20:27:51 +0000 (22:27 +0200)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 10 Jun 2025 12:15:42 +0000 (14:15 +0200)
commit0cee6c4d3518b2e757aedae78771f17149f57653
treefffa23e8220e9601e19c59af83ce230aeece2251
parentfaf2f8382088e8c74bd6eeb236c8c9190e61615e
drm/meson: fix more rounding issues with 59.94Hz modes

Commit 1017560164b6 ("drm/meson: use unsigned long long / Hz for
frequency types") attempts to resolve video playback using 59.94Hz.
 using YUV420 by changing the clock calculation to use
Hz instead of kHz (thus yielding more precision).

The basic calculation itself is correct, however the comparisions in
meson_vclk_vic_supported_freq() and meson_vclk_setup() don't work
anymore for 59.94Hz modes (using the freq * 1000 / 1001 logic). For
example, drm/edid specifies a 593407kHz clock for 3840x2160@59.94Hz.
With the mentioend commit we convert this to Hz. Then meson_vclk
tries to find a matchig "params" entry (as the clock setup code
currently only supports specific frequencies) by taking the venc_freq
from the params and calculating the "alt frequency" (used for the
59.94Hz modes) from it, which is:
  (594000000Hz * 1000) / 1001 = 593406593Hz

Similar calculation is applied to the phy_freq (TMDS clock), which is 10
times the pixel clock.

Implement a new meson_vclk_freqs_are_matching_param() function whose
purpose is to compare if the requested and calculated frequencies. They
may not match exactly (for the reasons mentioned above). Allow the
clocks to deviate slightly to make the 59.94Hz modes again.

Fixes: 1017560164b6 ("drm/meson: use unsigned long long / Hz for frequency types")
Reported-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250609202751.962208-1-martin.blumenstingl@googlemail.com
drivers/gpu/drm/meson/meson_vclk.c