]> www.infradead.org Git - users/jedix/linux-maple.git/commit
virtio_pci: fix use after free on release
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 14 Jan 2016 14:00:41 +0000 (16:00 +0200)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:44:33 +0000 (15:44 -0700)
commit0cd2bf5c125ad555db6804ed02f7280d9ba41227
tree4af6916b1ce751248ec8fcc259f7be149b0e4502
parentda334f9f7fd4dffe2da612d75f4d66f55b199a13
virtio_pci: fix use after free on release

Orabug: 23330783

[ Upstream commit 2989be09a8a9d62a785137586ad941f916e08f83 ]

KASan detected a use-after-free error in virtio-pci remove code. In
virtio_pci_remove(), vp_dev is still used after being freed in
unregister_virtio_device() (in virtio_pci_release_dev() more
precisely).

To fix, keep a reference until cleanup is done.

Fixes: 63bd62a08ca4 ("virtio_pci: defer kfree until release callback")
Reported-by: Jerome Marchand <jmarchan@redhat.com>
Cc: stable@vger.kernel.org
Cc: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Jerome Marchand <jmarchan@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 593bd1058b30eb4f0d6949afdfd9c2659d94ae1e)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
drivers/virtio/virtio_pci_common.c