]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: brcmstb: Use internal register to change link capability
authorJim Quinlan <james.quinlan@broadcom.com>
Fri, 14 Feb 2025 17:39:30 +0000 (12:39 -0500)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Tue, 4 Mar 2025 15:54:46 +0000 (15:54 +0000)
commit0c97321e11e0e9e18546f828492758f6aaecec59
tree97b754350a3c5297fef9be6a4f69e0ea207824f2
parent72d36589c6b7bef6b30eb99fcb7082f72faca37f
PCI: brcmstb: Use internal register to change link capability

The driver has been mistakenly writing to a read-only (RO)
configuration space register (PCI_EXP_LNKCAP) to change the
PCIe link capability.

Although harmless in this case, the proper write destination
is an internal register that is reflected by PCI_EXP_LNKCAP.

Thus, fix the brcm_pcie_set_gen() function to correctly update
the link capability.

Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20250214173944.47506-3-james.quinlan@broadcom.com
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/pcie-brcmstb.c