]> www.infradead.org Git - users/dwmw2/linux.git/commit
ipv6: do not use RT_TOS for IPv6 flowlabel
authorMatthias May <matthias.may@westermo.com>
Fri, 5 Aug 2022 19:19:06 +0000 (21:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:37:59 +0000 (11:37 +0200)
commit0c4542cb6ac82b405e9844592623b4a0e568dce7
treef0186b03621442bbc9826661f4c1e1e71e0673a5
parent38b83883ce4e4efe8ff0a727192219cac2668d42
ipv6: do not use RT_TOS for IPv6 flowlabel

commit ab7e2e0dfa5d37540ab1dc5376e9a2cb9188925d upstream.

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.")
Acked-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Matthias May <matthias.may@westermo.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv6/ip6_output.c