]> www.infradead.org Git - users/jedix/linux-maple.git/commit
trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump
authorYuran Pereira <yuran.pereira@hotmail.com>
Mon, 28 Oct 2024 19:21:00 +0000 (19:21 +0000)
committerDaniel Thompson <daniel.thompson@linaro.org>
Sat, 2 Nov 2024 08:33:13 +0000 (08:33 +0000)
commit0c10cc2435115c36dcb611f8e1ed99ba6de6f17f
tree70a65683380a658b4b5c8ddbb4cfb5ea28938c03
parent120fb87ced8eb95531ff69ec269fcbcc5be24e9c
trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

The function simple_strtoul performs no error checking in scenarios
where the input value overflows the intended output variable.
This results in this function successfully returning, even when the
output does not match the input string (aka the function returns
successfully even when the result is wrong).

Or as it was mentioned [1], "...simple_strtol(), simple_strtoll(),
simple_strtoul(), and simple_strtoull() functions explicitly ignore
overflows, which may lead to unexpected results in callers."
Hence, the use of those functions is discouraged.

This patch replaces all uses of the simple_strtoul with the safer
alternatives kstrtoint and kstrtol.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull

Signed-off-by: Yuran Pereira <yuran.pereira@hotmail.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
[nir: style fixes]
Signed-off-by: Nir Lichtman <nir@lichtman.org>
Link: https://lore.kernel.org/r/20241028192100.GB918454@lichtman.org
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
kernel/trace/trace_kdb.c