]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()
authorDouglas Anderson <dianders@chromium.org>
Tue, 14 May 2024 17:20:51 +0000 (10:20 -0700)
committerNeil Armstrong <neil.armstrong@linaro.org>
Wed, 15 May 2024 20:59:11 +0000 (22:59 +0200)
commit0b03829fdece47beba9ecb7dbcbde4585ee3663e
tree5291f8d842c49413529a7a9aa48f9018b0e0f60e
parent216afc2c11b7e920c81e356c7bc1221d81b8436b
drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

The mipi_dsi_dcs_write_seq() macro makes a call to
mipi_dsi_dcs_write_buffer() which returns a type ssize_t. The macro
then stores it in an int and checks to see if it's negative. This
could theoretically be a problem if "ssize_t" is larger than "int".

To see the issue, imagine that "ssize_t" is 32-bits and "int" is
16-bits, you could see a problem if there was some code out there that
looked like:

  mipi_dsi_dcs_write_seq(dsi, cmd, <32767 bytes as arguments>);

...since we'd get back that 32768 bytes were transferred and 32768
stored in a 16-bit int would look negative.

Though there are no callsites where we'd actually hit this (even if
"int" was only 16-bit), it's cleaner to make the types match so let's
fix it.

Fixes: 2a9e9daf7523 ("drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro")
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240514102056.v5.1.I30fa4c8348ea316c886ef8a522a52fed617f930d@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240514102056.v5.1.I30fa4c8348ea316c886ef8a522a52fed617f930d@changeid
include/drm/drm_mipi_dsi.h