]> www.infradead.org Git - users/dwmw2/linux.git/commit
mm: Fix missing folio invalidation calls during truncation
authorDavid Howells <dhowells@redhat.com>
Fri, 23 Aug 2024 20:08:09 +0000 (21:08 +0100)
committerChristian Brauner <brauner@kernel.org>
Sat, 24 Aug 2024 14:09:16 +0000 (16:09 +0200)
commit0aa2e1b2fb7a75aa4b5b4347055ccfea6f091769
treed979a2439783111a90a1aaede5186a3660f3dd1f
parentd10771d51b28f73aeb4e533207a294c1c1d45690
mm: Fix missing folio invalidation calls during truncation

When AS_RELEASE_ALWAYS is set on a mapping, the ->release_folio() and
->invalidate_folio() calls should be invoked even if PG_private and
PG_private_2 aren't set.  This is used by netfslib to keep track of the
point above which reads can be skipped in favour of just zeroing pagecache
locally.

There are a couple of places in truncation in which invalidation is only
called when folio_has_private() is true.  Fix these to check
folio_needs_release() instead.

Without this, the generic/075 and generic/112 xfstests (both fsx-based
tests) fail with minimum folio size patches applied[1].

Fixes: b4fa966f03b7 ("mm, netfs, fscache: stop read optimisation when folio removed from pagecache")
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/20240815090849.972355-1-kernel@pankajraghav.com/
Link: https://lore.kernel.org/r/20240823200819.532106-2-dhowells@redhat.com
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
cc: Matthew Wilcox (Oracle) <willy@infradead.org>
cc: Pankaj Raghav <p.raghav@samsung.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: netfs@lists.linux.dev
cc: linux-mm@kvack.org
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
mm/truncate.c