]> www.infradead.org Git - users/dwmw2/linux.git/commit
bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()
authorSuman Anna <s-anna@ti.com>
Tue, 25 Jun 2019 23:33:15 +0000 (18:33 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Sep 2019 05:18:27 +0000 (07:18 +0200)
commit0a3d2a039339b446cd8f901e65a5843a2962db3a
tree396e26e079ec82a1e2466d3266ded0f93a5b7df8
parente92814b0aae18a95fe6c5e7002b32fa9aaa0a640
bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()

[ Upstream commit a304f483b6b00d42bde41c45ca52c670945348e2 ]

The clocks are not yet parsed and prepared until after a successful
sysc_get_clocks(), so there is no need to unprepare the clocks upon
any failure of any of the prior functions in sysc_probe(). The current
code path would have been a no-op because of the clock validity checks
within sysc_unprepare(), but let's just simplify the cleanup path by
returning the error directly.

While at this, also fix the cleanup path for a sysc_init_resets()
failure which is executed after the clocks are prepared.

Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bus/ti-sysc.c