]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xen-netfront: Fix Rx stall during network stress and OOM
authorDongli Zhang <dongli.zhang@oracle.com>
Tue, 21 Mar 2017 23:24:08 +0000 (07:24 +0800)
committerDhaval Giani <dhaval.giani@oracle.com>
Mon, 29 May 2017 20:27:46 +0000 (16:27 -0400)
commit0a08f96c282e523a42eeb0e072e05aa4f431246f
tree20e232d97796d1b48ed1c26fec5aebbfba961b33
parent1892c8548e0183444773a8972e087295b82d29fe
xen-netfront: Fix Rx stall during network stress and OOM

Orabug: 25747721

During an OOM scenario, request slots could not be created as skb
allocation fails. So the netback cannot pass in packets and netfront
wrongly assumes that there is no more work to be done and it disables
polling. This causes Rx to stall.

The issue is with the retry logic which schedules the timer if the
created slots are less than NET_RX_SLOTS_MIN. The count of new request
slots to be pushed are calculated as a difference between new req_prod
and rsp_cons which could be more than the actual slots, if there are
unconsumed responses.

The fix is to calculate the count of newly created slots as the
difference between new req_prod and old req_prod.

Signed-off-by: Vineeth Remanan Pillai <vineethp@amazon.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Backport from upstream 90c311b0eeead647b708a723dbdde1eda3dcad05

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Acked-By: Joe Jin <joe.jin@oracle.com>
drivers/net/xen-netfront.c