]> www.infradead.org Git - users/hch/dma-mapping.git/commit
idpf: deinit virtchnl transaction manager after vport and vectors
authorLarysa Zaremba <larysa.zaremba@intel.com>
Wed, 4 Sep 2024 09:54:17 +0000 (11:54 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 30 Sep 2024 21:23:32 +0000 (14:23 -0700)
commit09d0fb5cb30ebcaed4a33028ae383f5a1463e2b2
treeb2a7958f4892b3dd8258644d5228d4dbe562d3fb
parent640f70063e6d3a76a63f57e130fba43ba8c7e980
idpf: deinit virtchnl transaction manager after vport and vectors

When the device is removed, idpf is supposed to make certain virtchnl
requests e.g. VIRTCHNL2_OP_DEALLOC_VECTORS and VIRTCHNL2_OP_DESTROY_VPORT.

However, this does not happen due to the referenced commit introducing
virtchnl transaction manager and placing its deinitialization before those
messages are sent. Then the sending is impossible due to no transactions
being available.

Lack of cleanup can lead to the FW becoming unresponsive from e.g.
unloading-loading the driver and creating-destroying VFs afterwards.

Move transaction manager deinitialization to after other virtchnl-related
cleanup is done.

Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c