]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rtc: tps6594: Fix integer overflow on 32bit systems
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 11 Dec 2024 09:32:34 +0000 (12:32 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 12 Jan 2025 23:20:55 +0000 (00:20 +0100)
commit09c4a610153286cef54d4f0c85398f4e32fc227e
tree8913bb973922a35240c5066c9e52c5da8b004445
parent8c28c4993f117e03130a51160229bde7ad388240
rtc: tps6594: Fix integer overflow on 32bit systems

The problem is this multiply in tps6594_rtc_set_offset()

tmp = offset * TICKS_PER_HOUR;

The "tmp" variable is an s64 but "offset" is a long in the
(-277774)-277774 range.  On 32bit systems a long can hold numbers up to
approximately two billion.  The number of TICKS_PER_HOUR is really large,
(32768 * 3600) or roughly a hundred million.  When you start multiplying
by a hundred million it doesn't take long to overflow the two billion
mark.

Probably the safest way to fix this is to change the type of
TICKS_PER_HOUR to long long because it's such a large number.

Fixes: 9f67c1e63976 ("rtc: tps6594: Add driver for TPS6594 RTC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/1074175e-5ecb-4e3d-b721-347d794caa90@stanley.mountain
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-tps6594.c