]> www.infradead.org Git - nvme.git/commit
net: usb: sr9700: fix uninitialized variable use in sr_mdio_read
authorMa Ke <make24@iscas.ac.cn>
Thu, 25 Jul 2024 02:29:42 +0000 (10:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Jul 2024 10:14:41 +0000 (11:14 +0100)
commit08f3a5c38087d1569e982a121aad1e6acbf145ce
tree50ede35f80ad22aeedcacdbfa5e3297558a8c824
parent07c10cff663e54dadff7cfb6cf09e266456ed073
net: usb: sr9700: fix uninitialized variable use in sr_mdio_read

It could lead to error happen because the variable res is not updated if
the call to sr_share_read_word returns an error. In this particular case
error code was returned and res stayed uninitialized. Same issue also
applies to sr_read_reg.

This can be avoided by checking the return value of sr_share_read_word
and sr_read_reg, and propagating the error if the read operation failed.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Shigeru Yoshida <syoshida@redhat.com>
Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/sr9700.c