]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pinctrl: s32cc: Avoid possible string truncation
authorChester Lin <clin@suse.com>
Tue, 7 Nov 2023 14:10:44 +0000 (22:10 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 14 Nov 2023 13:43:37 +0000 (14:43 +0100)
commit08e8734d877a9a0fb8af1254a4ce58734fbef296
treed7dd4c91dcbd6b0d121922966fe45177654224a4
parentedd48fd9d45370d6c8ba0dd834fcc51ff688cc87
pinctrl: s32cc: Avoid possible string truncation

With "W=1" and "-Wformat-truncation" build options, the kernel test robot
found a possible string truncation warning in pinctrl-s32cc.c, which uses
an 8-byte char array to hold a memory region name "map%u". Since the
maximum number of digits that a u32 value can present is 10, and the "map"
string occupies 3 bytes with a termination '\0', which means the rest 4
bytes cannot fully present the integer "X" that exceeds 4 digits.

Here we check if the number >= 10000, which is the lowest value that
contains more than 4 digits.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311030159.iyUGjNGF-lkp@intel.com/
Signed-off-by: Chester Lin <clin@suse.com>
Link: https://lore.kernel.org/r/20231107141044.24058-1-clin@suse.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/nxp/pinctrl-s32cc.c