]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: avoid signed overflows for SO_{SND|RCV}BUFFORCE
authorEric Dumazet <edumazet@google.com>
Fri, 2 Dec 2016 17:44:53 +0000 (09:44 -0800)
committerDhaval Giani <dhaval.giani@oracle.com>
Mon, 16 Jan 2017 21:43:59 +0000 (16:43 -0500)
commit08c8ced203fabc34708b0a4cec89708fe98c64bf
tree39c4955a12fb77997a98064c7de498e041161572
parent6351915b5acda403e63badcc48a3683bd9b3aa4c
net: avoid signed overflows for SO_{SND|RCV}BUFFORCE

CAP_NET_ADMIN users should not be allowed to set negative
sk_sndbuf or sk_rcvbuf values, as it can lead to various memory
corruptions, crashes, OOM...

Note that before commit 82981930125a ("net: cleanups in
sock_setsockopt()"), the bug was even more serious, since SO_SNDBUF
and SO_RCVBUF were vulnerable.

This needs to be backported to all known linux kernels.

Again, many thanks to syzkaller team for discovering this gem.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit b98b0bc8c431e3ceb4b26b0dfc8db509518fb290)

Orabug: 25203090
CVE: CVE-2016-9793
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
net/core/sock.c