]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"
authorChristian König <christian.koenig@amd.com>
Wed, 10 Jan 2024 14:19:29 +0000 (15:19 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 18 Jan 2024 20:42:20 +0000 (15:42 -0500)
commit087a3e13ec49358eda582176a50068d38d94080f
tree68c2af5e13f665fd305cba3c1a9d87564f53db36
parent8a1f7fddabe112f463c2fd5d1e41c9c87d0a9957
drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"

Calling amdgpu_device_ip_resume_phase1() during shutdown leaves the
HW in an active state and is an unbalanced use of the IP callbacks.

Using the IP callbacks like this can lead to memory leaks, double
free and imbalanced reference counters.

Leaving the HW in an active state can lead to DMA accesses to memory now
freed by the driver.

Both is a complete no-go for driver unload so completely revert the
workaround for now.

This reverts commit f5c7e7797060255dbc8160734ccc5ad6183c5e04.

Signed-off-by: Christian König <christian.koenig@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.h