]> www.infradead.org Git - users/hch/misc.git/commit
drm/display: use ERR_PTR on DP tunnel manager creation fail
authorKrzysztof Karas <krzysztof.karas@intel.com>
Thu, 12 Dec 2024 11:00:41 +0000 (11:00 +0000)
committerImre Deak <imre.deak@intel.com>
Fri, 13 Dec 2024 16:57:34 +0000 (18:57 +0200)
commit080b2e7b5e9ad23343e4b11f0751e4c724a78958
tree7fc2ad1308672fdd76c29af3d60fc4624fb7db68
parentd2bd3fcb825725a59c8880070b1206b1710922bd
drm/display: use ERR_PTR on DP tunnel manager creation fail

Instead of returning a generic NULL on error from
drm_dp_tunnel_mgr_create(), use error pointers with informative codes
to align the function with stub that is executed when
CONFIG_DRM_DISPLAY_DP_TUNNEL is unset. This will also trigger IS_ERR()
in current caller (intel_dp_tunnerl_mgr_init()) instead of bypassing it
via NULL pointer.

v2: use error codes inside drm_dp_tunnel_mgr_create() instead of handling
 on caller's side (Michal, Imre)

v3: fixup commit message and add "CC"/"Fixes" lines (Andi),
 mention aligning function code with stub

Fixes: 91888b5b1ad2 ("drm/i915/dp: Add support for DP tunnel BW allocation")
Cc: Imre Deak <imre.deak@intel.com>
Cc: <stable@vger.kernel.org> # v6.9+
Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/7q4fpnmmztmchczjewgm6igy55qt6jsm7tfd4fl4ucfq6yg2oy@q4lxtsu6445c
drivers/gpu/drm/display/drm_dp_tunnel.c