]> www.infradead.org Git - users/jedix/linux-maple.git/commit
spi: geni-qcom: Use devm functions to simplify code
authorJinjie Ruan <ruanjinjie@huawei.com>
Thu, 12 Sep 2024 09:17:01 +0000 (17:17 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 12 Sep 2024 11:39:04 +0000 (12:39 +0100)
commit07f1eb718db281c3e0cdb068ea7d73c30921a81c
tree9fab05dc97f3415a8f127beba52b510f430ea266
parentf10d52087cbe85dcff2af3dc94c5b9d06e6d4b9a
spi: geni-qcom: Use devm functions to simplify code

Use devm_pm_runtime_enable(), devm_request_irq() and
devm_spi_register_controller() to simplify code.

And also register a callback spi_geni_release_dma_chan() with
devm_add_action_or_reset(), to release dma channel in both error
and device detach path, which can make sure the release sequence is
consistent with the original one.

1. Unregister spi controller.
2. Free the IRQ.
3. Free DMA chans
4. Disable runtime PM.

So the remove function can also be removed.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Suggested-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20240912091701.3720857-1-ruanjinjie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-geni-qcom.c