]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfs: check for dead buffers in xfs_buf_find_insert
authorChristoph Hellwig <hch@lst.de>
Thu, 16 Jan 2025 06:01:41 +0000 (07:01 +0100)
committerCarlos Maiolino <cem@kernel.org>
Thu, 16 Jan 2025 09:19:59 +0000 (10:19 +0100)
commit07eae0fa67ca4bbb199ad85645e0f9dfaef931cd
treea91dceb852e028253fd45b4aff5efbff37e64d15
parent4e35be63c4ad880c3dba12a287a0ea196541258e
xfs: check for dead buffers in xfs_buf_find_insert

Commit 32dd4f9c506b ("xfs: remove a superflous hash lookup when inserting
new buffers") converted xfs_buf_find_insert to use
rhashtable_lookup_get_insert_fast and thus an operation that returns the
existing buffer when an insert would duplicate the hash key.  But this
code path misses the check for a buffer with a reference count of zero,
which could lead to reusing an about to be freed buffer.  Fix this by
using the same atomic_inc_not_zero pattern as xfs_buf_insert.

Fixes: 32dd4f9c506b ("xfs: remove a superflous hash lookup when inserting new buffers")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Cc: stable@vger.kernel.org # v6.0
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_buf.c