]> www.infradead.org Git - users/dwmw2/linux.git/commit
x86/mm/pti: Handle unaligned address gracefully in pti_clone_pagetable()
authorSong Liu <songliubraving@fb.com>
Wed, 28 Aug 2019 21:54:55 +0000 (23:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 11:13:51 +0000 (13:13 +0200)
commit07e66eb2a8c00a00fe19efaaf8e3378b443c106f
tree74daec339fc28ed031c846792785b49cf4dc7833
parent6198f3954f1536b5a053a4ec691e4758cb0501ea
x86/mm/pti: Handle unaligned address gracefully in pti_clone_pagetable()

[ Upstream commit 825d0b73cd7526b0bb186798583fae810091cbac ]

pti_clone_pmds() assumes that the supplied address is either:

 - properly PUD/PMD aligned
or
 - the address is actually mapped which means that independently
   of the mapping level (PUD/PMD/PTE) the next higher mapping
   exists.

If that's not the case the unaligned address can be incremented by PUD or
PMD size incorrectly. All callers supply mapped and/or aligned addresses,
but for the sake of robustness it's better to handle that case properly and
to emit a warning.

[ tglx: Rewrote changelog and added WARN_ON_ONCE() ]

Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1908282352470.1938@nanos.tec.linutronix.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/mm/pti.c