]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 18 Oct 2024 15:21:10 +0000 (15:21 +0000)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 21 Feb 2025 09:33:00 +0000 (10:33 +0100)
commit07df4f23ef3ffe6fee697cd2e03623ad27108843
tree63cbbe31321d79de19b5453a8aaecb3089ffd604
parent955a999ca2336869a01bbc2d346185c348929e78
media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warning

This is one of three clang warnings about incompatible enum types
in a conditional expression:

drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c:597:29: error: conditional expression between different enumeration types ('enum scp_ipi_id' and 'enum ipi_id') [-Werror,-Wenum-compare-conditional]
  597 |         inst->vpu_inst.id = is_ext ? SCP_IPI_VENC_H264 : IPI_VENC_H264;
      |                                    ^ ~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~~

The code is correct, so just rework it to avoid the warning.

Fixes: 0dc4b3286125 ("media: mtk-vcodec: venc: support SCP firmware")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Alexandre Courbot <acourbot@google.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c