]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cxl/core/regs.c: Skip Memory Space Enable check for RCD and RCH Ports
authorSmita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Mon, 7 Apr 2025 19:27:34 +0000 (19:27 +0000)
committerDave Jiang <dave.jiang@intel.com>
Mon, 21 Apr 2025 15:30:13 +0000 (08:30 -0700)
commit078d3ee7c162cd66d76171579c02d7890bd77daf
tree2b3c29b7fd1d7704e464b1ec251104ae592ea9ae
parent25174d5cd22f0977034892672a0287f7febcec1c
cxl/core/regs.c: Skip Memory Space Enable check for RCD and RCH Ports

According to CXL r3.2 section 8.2.1.2, the PCI_COMMAND register fields,
including Memory Space Enable bit, have no effect on the behavior of an
RCD Upstream Port. Retaining this check may incorrectly cause
cxl_pci_probe() to fail on a valid RCD upstream Port.

While the specification is explicit only for RCD Upstream Ports, this
check is solely for accessing the RCRB, which is always mapped through
memory space. Therefore, its safe to remove the check entirely. In
practice, firmware reliably enables the Memory Space Enable bit for
RCH Downstream Ports and no failures have been observed.

Removing the check simplifies the code and avoids unnecessary
special-casing, while relying on BIOS/firmware to configure devices
correctly. Moreover, any failures due to inaccessible RCRB regions
will still be caught either in __rcrb_to_component() or while
parsing the component register block.

The following failure was observed in dmesg when the check was present:
cxl_pci 0000:7f:00.0: No component registers (-6)

Fixes: d5b1a27143cb ("cxl/acpi: Extract component registers of restricted hosts from RCRB")
Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Terry Bowman <terry.bowman@amd.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Robert Richter <rrichter@amd.com>
Link: https://patch.msgid.link/20250407192734.70631-1-Smita.KoralahalliChannabasappa@amd.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/regs.c