]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: intel-ish-hid: Fix use-after-free issue in ishtp_hid_remove()
authorZhang Lixu <lixu.zhang@intel.com>
Tue, 18 Feb 2025 06:37:30 +0000 (14:37 +0800)
committerJiri Kosina <jkosina@suse.com>
Wed, 19 Feb 2025 09:09:27 +0000 (10:09 +0100)
commit07583a0010696a17fb0942e0b499a62785c5fc9f
treedf18d8ec1fefc3746ee587c0c62a8105e30dfd06
parent823987841424289339fdb4ba90e6d2c3792836db
HID: intel-ish-hid: Fix use-after-free issue in ishtp_hid_remove()

The system can experience a random crash a few minutes after the driver is
removed. This issue occurs due to improper handling of memory freeing in
the ishtp_hid_remove() function.

The function currently frees the `driver_data` directly within the loop
that destroys the HID devices, which can lead to accessing freed memory.
Specifically, `hid_destroy_device()` uses `driver_data` when it calls
`hid_ishtp_set_feature()` to power off the sensor, so freeing
`driver_data` beforehand can result in accessing invalid memory.

This patch resolves the issue by storing the `driver_data` in a temporary
variable before calling `hid_destroy_device()`, and then freeing the
`driver_data` after the device is destroyed.

Fixes: 0b28cb4bcb17 ("HID: intel-ish-hid: ISH HID client driver")
Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-ish-hid/ishtp-hid.c