]> www.infradead.org Git - users/dwmw2/linux.git/commit
can: mcan: m_can_class_unregister(): fix order of unregistration calls
authorMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 2 May 2025 14:13:46 +0000 (16:13 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 6 May 2025 13:54:36 +0000 (15:54 +0200)
commit0713a1b3276b98c7dafbeefef00d7bc3a9119a84
treed4aaf0bca5e74a661277489734d3aa9909c8d821
parent037ada7a3181300218e4fd78bef6a741cfa7f808
can: mcan: m_can_class_unregister(): fix order of unregistration calls

If a driver is removed, the driver framework invokes the driver's
remove callback. A CAN driver's remove function calls
unregister_candev(), which calls net_device_ops::ndo_stop further down
in the call stack for interfaces which are in the "up" state.

The removal of the module causes a warning, as can_rx_offload_del()
deletes the NAPI, while it is still active, because the interface is
still up.

To fix the warning, first unregister the network interface, which
calls net_device_ops::ndo_stop, which disables the NAPI, and then call
can_rx_offload_del().

Fixes: 1be37d3b0414 ("can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context")
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-3-59a9b131589d@pengutronix.de
Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c