]> www.infradead.org Git - users/jedix/linux-maple.git/commit
Revert "clk: Fix invalid execution of clk_set_rate"
authorJohan Hovold <johan+linaro@kernel.org>
Mon, 2 Dec 2024 10:06:21 +0000 (11:06 +0100)
committerStephen Boyd <sboyd@kernel.org>
Tue, 3 Dec 2024 01:20:12 +0000 (17:20 -0800)
commit06fec99d4d2cb92bc6f107fdfd5e5c776375c68a
treebba7533ecab9a52b64f99fc7dff0147223208645
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
Revert "clk: Fix invalid execution of clk_set_rate"

This reverts commit 25f1c96a0e841013647d788d4598e364e5c2ebb7.

The offending commit results in errors like

cpu cpu0: _opp_config_clk_single: failed to set clock rate: -22

spamming the logs on the Lenovo ThinkPad X13s and other Qualcomm
machines when cpufreq tries to update the CPUFreq HW Engine clocks.

As mentioned in commit 4370232c727b ("cpufreq: qcom-hw: Add CPU clock
provider support"):

[T]he frequency supplied by the driver is the actual frequency
that comes out of the EPSS/OSM block after the DCVS operation.
This frequency is not same as what the CPUFreq framework has set
but it is the one that gets supplied to the CPUs after
throttling by LMh.

which seems to suggest that the driver relies on the previous behaviour
of clk_set_rate().

Since this affects many Qualcomm machines, let's revert for now.

Fixes: 25f1c96a0e84 ("clk: Fix invalid execution of clk_set_rate")
Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
Link: https://lore.kernel.org/all/e2d83e57-ad07-411b-99f6-a4fc3c4534fa@arm.com/
Cc: Chuan Liu <chuan.liu@amlogic.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20241202100621.29209-1-johan+linaro@kernel.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c