]> www.infradead.org Git - users/dwmw2/linux.git/commit
arm64: dts: rockchip: Fix UART pull-ups on rk3328
authorChen-Yu Tsai <wens@csie.org>
Fri, 4 Dec 2020 06:48:05 +0000 (14:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Dec 2020 12:46:58 +0000 (13:46 +0100)
commit06bfebfa88d9b91883ba45cf5264ff4f1e010a16
tree25e0067d97085976d274d9eff1f71d3adfd41ec3
parent7cc1056d2cc5caa8236139ef56e3688e869647b8
arm64: dts: rockchip: Fix UART pull-ups on rk3328

[ Upstream commit 94dad6bed3c86c00050bf7c2b2ad6b630facae31 ]

For UARTs, the local pull-ups should be on the RX pin, not the TX pin.
UARTs transmit active-low, so a disconnected RX pin should be pulled
high instead of left floating to prevent noise being interpreted as
transmissions.

This gets rid of bogus sysrq events when the UART console is not
connected.

Fixes: 52e02d377a72 ("arm64: dts: rockchip: add core dtsi file for RK3328 SoCs")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20201204064805.6480-1-wens@kernel.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/rockchip/rk3328.dtsi