]> www.infradead.org Git - users/jedix/linux-maple.git/commit
serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND
authorHugo Villeneuve <hvilleneuve@dimonoff.com>
Mon, 7 Oct 2024 16:27:15 +0000 (12:27 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Oct 2024 06:14:54 +0000 (08:14 +0200)
commit068d35a7be65fa3bca4bba21c269bfe0b39158a6
tree4a8294918b1098539d600e6ae226ecbc30d68ab2
parent0927c649230a960cdc22ebdd8f2db96bba21b233
serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND

When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration,
we get the following warning after commit 4afeced55baa ("serial: core:
fix sanitizing check for RTS settings"):

    invalid RTS setting, using RTS_AFTER_SEND instead

This results in SER_RS485_RTS_AFTER_SEND being set and the
driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT,
which breaks some hardware using these chips.

The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix
this by announcing support for RTS_ON_SEND.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Suggested-by: Konstantin Pugin <ria.freelander@gmail.com>
Link: https://lore.kernel.org/lkml/20240422133219.2710061-2-ria.freelander@gmail.com
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Tested-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20241007162716.3122912-1-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sc16is7xx.c