]> www.infradead.org Git - users/jedix/linux-maple.git/commit
riscv: KVM: Fix SBI IPI error generation
authorAndrew Jones <ajones@ventanamicro.com>
Mon, 17 Feb 2025 08:45:10 +0000 (09:45 +0100)
committerAnup Patel <anup@brainfault.org>
Mon, 17 Feb 2025 10:58:28 +0000 (16:28 +0530)
commit0611f78f83c93c000029ab01daa28166d03590ed
tree65f2453837d5800fe49421cf112c1046a7f45b42
parente3219b0c491f2aa0e0b200a39d3352ab05cdda96
riscv: KVM: Fix SBI IPI error generation

When an invalid function ID of an SBI extension is used we should
return not-supported, not invalid-param. Also, when we see that at
least one hartid constructed from the base and mask parameters is
invalid, then we should return invalid-param. Finally, rather than
relying on overflowing a left shift to result in zero and then using
that zero in a condition which [correctly] skips sending an IPI (but
loops unnecessarily), explicitly check for overflow and exit the loop
immediately.

Fixes: 5f862df5585c ("RISC-V: KVM: Add v0.1 replacement SBI extensions defined in v0.2")
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20250217084506.18763-10-ajones@ventanamicro.com
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/vcpu_sbi_replace.c