]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: hid-steam: Fix issues with disabling both gamepad mode and lizard mode
authorVicki Pfau <vi@endrift.com>
Thu, 16 Jan 2025 01:28:16 +0000 (17:28 -0800)
committerJiri Kosina <jkosina@suse.com>
Mon, 3 Feb 2025 10:17:40 +0000 (11:17 +0100)
commit05c4ede6951b5d8e083b6bb237950cac59bdeb92
tree73b8090c8e4f060d3961bb59748c4e2e3a096c43
parent363236d709e75610b628c2a4337ccbe42e454b6d
HID: hid-steam: Fix issues with disabling both gamepad mode and lizard mode

When lizard mode is disabled, there were two issues:

1. Switching between gamepad mode and desktop mode still functioned, even
though desktop mode did not. This lead to the ability to "break" gamepad mode
by holding down the Options key even while lizard mode is disabled

2. If you were in desktop mode when lizard mode is disabled, you would
immediately enter this faulty mode.

This patch properly disables the ability to switch between gamepad mode and the
faulty desktop mode by holding the Options key, as well as effectively removing
the faulty mode by bypassing the early returns if lizard mode is disabled.

Reported-by: Eugeny Shcheglov <eugenyshcheglov@gmail.com>
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-steam.c