]> www.infradead.org Git - users/willy/xarray.git/commit
pinctrl: th1520: Fix potential null pointer dereference on func
authorColin Ian King <colin.i.king@gmail.com>
Wed, 16 Oct 2024 15:56:55 +0000 (16:56 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 16 Oct 2024 19:30:18 +0000 (21:30 +0200)
commit05214b06ee832854bfae883de0522e3c48d4444b
treee73ade01c5ba2e686389c8a798276fa9544e3cee
parent22c918258f90600665b44a9bc29d09d6f7837a6a
pinctrl: th1520: Fix potential null pointer dereference on func

The initialization of muxtype deferences pointer func before func
is sanity checked with a null pointer check, hence we have a null
pointer deference issue. Fix this by only deferencing func with
the assignment to muxtype after func has been null pointer checked.

Fixes: 1fc30cd92770 ("pinctrl: th1520: Factor out casts")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reported-by: Kees Bakker <kees@ijzerbout.nl>
Acked-by: Drew Fustini <dfustini@tenstorrent.com>
Link: https://lore.kernel.org/20241016155655.334518-1-colin.i.king@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-th1520.c