]> www.infradead.org Git - users/jedix/linux-maple.git/commit
leds: netxbig: Fix an OF node reference leak in netxbig_leds_get_of_pdata()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Mon, 16 Dec 2024 07:49:23 +0000 (16:49 +0900)
committerLee Jones <lee@kernel.org>
Tue, 17 Dec 2024 15:01:11 +0000 (15:01 +0000)
commit0508316be63bb735f59bdc8fe4527cadb62210ca
tree6703eb414c035b4f9b1b03d4725b057de82238a6
parent1c896113f04e34d0036ef506532d2e6cf77dd1e5
leds: netxbig: Fix an OF node reference leak in netxbig_leds_get_of_pdata()

netxbig_leds_get_of_pdata() does not release the OF node obtained by
of_parse_phandle() when of_find_device_by_node() fails. Add an
of_node_put() call to fix the leak.

This bug was found by an experimental static analysis tool that I am
developing.

Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://lore.kernel.org/r/20241216074923.628509-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-netxbig.c