]> www.infradead.org Git - users/dwmw2/linux.git/commit
soc: ti: Fix reference imbalance in knav_dma_probe
authorZhang Qilong <zhangqilong3@huawei.com>
Sun, 22 Nov 2020 03:22:37 +0000 (19:22 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Dec 2020 12:46:54 +0000 (13:46 +0100)
commit0477232db1bc5ac481e627d594fc0735ec618d1b
treeb7d6c30fd05976bae4ea0ff3a409a39b4c257e32
parent4f3670e788ad1b281b921f6969f9f434a940713f
soc: ti: Fix reference imbalance in knav_dma_probe

[ Upstream commit b4fa73358c306d747a2200aec6f7acb97e5750e6 ]

The patch fix two reference leak.

  1) pm_runtime_get_sync will increment pm usage counter even it
     failed. Forgetting to call put operation will result in
     reference leak.

  2) The pm_runtime_enable will increase power disable depth. Thus
     a pairing decrement is needed on the error handling path to
     keep it balanced.

We fix it by: 1) adding call pm_runtime_put_noidle or
pm_runtime_put_sync in error handling. 2) adding pm_runtime_disable
in error handling, to keep usage counter and disable depth balanced.

Fixes: 88139ed030583 ("soc: ti: add Keystone Navigator DMA support")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/ti/knav_dma.c