]> www.infradead.org Git - users/dwmw2/linux.git/commit
PCI: qcom: Prevent use of uninitialized data in qcom_pcie_suspend_noirq()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 8 Jul 2024 18:05:38 +0000 (13:05 -0500)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Wed, 10 Jul 2024 05:39:15 +0000 (05:39 +0000)
commit044b45be04cb16125a0eccba532e88dc529f64de
tree23715c931d56248fb026b57ab5c9fa867ccc326d
parent9553636b5757789536d0d23c83e7fba11812f958
PCI: qcom: Prevent use of uninitialized data in qcom_pcie_suspend_noirq()

Smatch complains that "ret" could be uninitialized if "pcie->icc_mem" is
NULL and "pm_suspend_target_state == PM_SUSPEND_MEM".

Silence this warning by initializing ret to zero.

Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance")
Link: https://lore.kernel.org/linux-pci/20240708180539.1447307-4-dan.carpenter@linaro.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/controller/dwc/pcie-qcom.c