]> www.infradead.org Git - users/jedix/linux-maple.git/commit
irqchip/riscv-aplic: Retrigger MSI interrupt on source configuration
authorYong-Xuan Wang <yongxuan.wang@sifive.com>
Fri, 9 Aug 2024 07:10:47 +0000 (15:10 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Sat, 10 Aug 2024 08:42:04 +0000 (10:42 +0200)
commit03f9885c60adf73488fe32aab628ee3d4a39598e
tree71051b75f1dfffc622ce2524ea86f680527ed81b
parentd73f0f49daa84176c3beee1606e73c7ffb6af8b2
irqchip/riscv-aplic: Retrigger MSI interrupt on source configuration

The section 4.5.2 of the RISC-V AIA specification says that "any write
to a sourcecfg register of an APLIC might (or might not) cause the
corresponding interrupt-pending bit to be set to one if the rectified
input value is high (= 1) under the new source mode."

When the interrupt type is changed in the sourcecfg register, the APLIC
device might not set the corresponding pending bit, so the interrupt might
never become pending.

To handle sourcecfg register changes for level-triggered interrupts in MSI
mode, manually set the pending bit for retriggering interrupt so it gets
retriggered if it was already asserted.

Fixes: ca8df97fe679 ("irqchip/riscv-aplic: Add support for MSI-mode")
Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Vincent Chen <vincent.chen@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20240809071049.2454-1-yongxuan.wang@sifive.com
drivers/irqchip/irq-riscv-aplic-msi.c