]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: ethernet: ti: cpsw_ale: Fix cpsw_ale_get_field()
authorSudheer Kumar Doredla <s-doredla@ti.com>
Wed, 8 Jan 2025 17:24:33 +0000 (22:54 +0530)
committerJakub Kicinski <kuba@kernel.org>
Fri, 10 Jan 2025 02:02:56 +0000 (18:02 -0800)
commit03d120f27d050336f7e7d21879891542c4741f81
tree8fffeed4c711f64482c5552737d9916c58491757
parentc77cd47cee041bc1664b8e5fcd23036e5aab8e2a
net: ethernet: ti: cpsw_ale: Fix cpsw_ale_get_field()

CPSW ALE has 75-bit ALE entries stored across three 32-bit words.
The cpsw_ale_get_field() and cpsw_ale_set_field() functions support
ALE field entries spanning up to two words at the most.

The cpsw_ale_get_field() and cpsw_ale_set_field() functions work as
expected when ALE field spanned across word1 and word2, but fails when
ALE field spanned across word2 and word3.

For example, while reading the ALE field spanned across word2 and word3
(i.e. bits 62 to 64), the word3 data shifted to an incorrect position
due to the index becoming zero while flipping.
The same issue occurred when setting an ALE entry.

This issue has not been seen in practice but will be an issue in the future
if the driver supports accessing ALE fields spanning word2 and word3

Fix the methods to handle getting/setting fields spanning up to two words.

Fixes: b685f1a58956 ("net: ethernet: ti: cpsw_ale: Fix cpsw_ale_get_field()/cpsw_ale_set_field()")
Signed-off-by: Sudheer Kumar Doredla <s-doredla@ti.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Link: https://patch.msgid.link/20250108172433.311694-1-s-doredla@ti.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/cpsw_ale.c