]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xen/events: fix unmask_evtchn for PV on HVM guests
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Wed, 22 Aug 2012 16:20:11 +0000 (17:20 +0100)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Tue, 4 Dec 2012 17:32:47 +0000 (12:32 -0500)
commit038ea9930b05f04efdfebc000eff927b0d5092cf
tree59abdd1bf6aa93fcaa88df110c56f73c0bf6dc41
parent5ea6804977682d6940620be057cd0f4df662fe2e
xen/events: fix unmask_evtchn for PV on HVM guests

When unmask_evtchn is called, if we already have an event pending, we
just set evtchn_pending_sel waiting for local_irq_enable to be called.
That is because PV guests set the irq_enable pvops to
xen_irq_enable_direct in xen_setup_vcpu_info_placement:
xen_irq_enable_direct is implemented in assembly in
arch/x86/xen/xen-asm.S and call xen_force_evtchn_callback if
XEN_vcpu_info_pending is set.

However HVM guests (and ARM guests) do not change or do not have the
irq_enable pvop, so evtchn_unmask cannot work properly for them.

Considering that having the pending_irq bit set when unmask_evtchn is
called is not very common, and it is simpler to keep the
native_irq_enable implementation for HVM guests (and ARM guests), the
best thing to do is just use the EVTCHNOP_unmask hypercall (Xen
re-injects pending events in response).

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
(cherry picked from commit b5e579232d635b79a3da052964cb357ccda8d9ea)
drivers/xen/events.c