]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PM: sleep: Use two lines for "Restarting..." / "done" messages
authorAndrew Sayers <kernel.org@pileofstuff.org>
Fri, 11 Apr 2025 15:25:04 +0000 (16:25 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 22 Apr 2025 11:58:30 +0000 (13:58 +0200)
commit036c94c9fd05824f86a92db115eba2773cc79231
tree28f06cd406a8f9edf388b357538895b35e60e37e
parent443046d1ad66607f324c604b9fbdf11266fa8aad
PM: sleep: Use two lines for "Restarting..." / "done" messages

Other messages are occasionally printed between these two, for example:

    [203104.106534] Restarting tasks ...
    [203104.106559] mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_ops [i915])
    [203104.112354] done.

This seems to be a timing issue, seen in two of the eleven
hibernation exits in my current `dmesg` output.

When printed on its own, the "done" message has the default log level.
This makes the output of `dmesg --level=warn` quite misleading.

Add enough context for the "done" messages to make sense on their own,
and use the same log level for all messages.

Change the messages to "<event>..." / "Done <event>.", unlike a449dfbfc089
which uses "<event>..." / "<event> completed.".  Front-loading the unique
part of the message makes it easier to scan the log, and reduces ambiguity
for users who aren't confident in their English comprehension.

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
Link: https://patch.msgid.link/20250411152632.2806038-1-kernel.org@pileofstuff.org
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/power/process.c
tools/power/pm-graph/sleepgraph.py