]> www.infradead.org Git - users/willy/pagecache.git/commit
NFSD: fix hang in nfsd4_shutdown_callback
authorDai Ngo <dai.ngo@oracle.com>
Thu, 30 Jan 2025 19:01:27 +0000 (11:01 -0800)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 10 Feb 2025 18:31:16 +0000 (13:31 -0500)
commit036ac2778f7b28885814c6fbc07e156ad1624d03
tree92cf910c99cdd588fd1fbbccaac4147a5a45ff8c
parentd9d6b74e4be989f919498798fa40df37a74b5bb0
NFSD: fix hang in nfsd4_shutdown_callback

If nfs4_client is in courtesy state then there is no point to send
the callback. This causes nfsd4_shutdown_callback to hang since
cl_cb_inflight is not 0. This hang lasts about 15 minutes until TCP
notifies NFSD that the connection was dropped.

This patch modifies nfsd4_run_cb_work to skip the RPC call if
nfs4_client is in courtesy state.

Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Fixes: 66af25799940 ("NFSD: add courteous server support for thread with only delegation")
Cc: stable@vger.kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4callback.c