]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bcachefs: don't return fsck_fix for unfixable node errors in __btree_err
authorBharadwaj Raju <bharadwaj.raju777@gmail.com>
Sun, 15 Jun 2025 16:45:38 +0000 (22:15 +0530)
committerKent Overstreet <kent.overstreet@linux.dev>
Mon, 16 Jun 2025 23:03:52 +0000 (19:03 -0400)
commit03208bd06a61bc2ebc423b6485cbcffecd37af36
treeed4c1e37b6a5078469b8318ddcaa0c97b78d9145
parent56be92c63f02e0f6fd855075acb1471ea1c68539
bcachefs: don't return fsck_fix for unfixable node errors in __btree_err

After cd3cdb1ef706 ("Single err message for btree node reads"),
all errors caused __btree_err to return -BCH_ERR_fsck_fix no matter what
the actual error type was if the recovery pass was scanning for btree
nodes. This lead to the code continuing despite things like bad node
formats when they earlier would have caused a jump to fsck_err, because
btree_err only jumps when the return from __btree_err does not match
fsck_fix. Ultimately this lead to undefined behavior by attempting to
unpack a key based on an invalid format.

Make only errors of type -BCH_ERR_btree_node_read_err_fixable cause
__btree_err to return -BCH_ERR_fsck_fix when scanning for btree nodes.

Reported-by: syzbot+cfd994b9cdf00446fd54@syzkaller.appspotmail.com
Fixes: cd3cdb1ef706 ("bcachefs: Single err message for btree node reads")
Signed-off-by: Bharadwaj Raju <bharadwaj.raju777@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_io.c